Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(medusa): Implement premises of the creation flow of an order edit #2187

Merged
merged 1 commit into from
Sep 16, 2022
Merged

feat(medusa): Implement premises of the creation flow of an order edit #2187

merged 1 commit into from
Sep 16, 2022

Conversation

adrien2p
Copy link
Member

@adrien2p adrien2p commented Sep 12, 2022 •
edited
Loading

What

  • Implements the admin create end point
  • Service implementation of the create method and the retrieveActive as well as the totals computation
  • Improve compute line items
  • client
    • medusa-js api
    • medusa-react mutations hooks

Tests

  • Unit tests of the create end points
  • Unit tests of the service create method
  • Integration tests for admin that also take into account totals computations
  • client
    • medusa-js tests
    • medusa-react hooks tests

FIXES CORE-491

@changeset-bot
Copy link

changeset-bot bot commented Sep 12, 2022 •
edited
Loading

⚠️ No Changeset found

Latest commit: bb315ad

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@adrien2p adrien2p force-pushed the feat/order-edit-retrieve branch 4 times, most recently from 538fa6c to bc3db93 Compare September 14, 2022 11:56
@adrien2p adrien2p force-pushed the feat/order-edit-retrieve branch from 66b1051 to 1da5e3e Compare September 14, 2022 17:00
@pKorsholm
Copy link
Contributor

Remember to include changes to medusa-js and medusa-react in the pr @adrien2p

@adrien2p adrien2p force-pushed the feat/order-edit-creation branch from 6b3c6f7 to 7674a1f Compare September 15, 2022 09:25
@adrien2p adrien2p changed the base branch from feat/order-edit-retrieve to develop September 15, 2022 09:25
@adrien2p adrien2p changed the base branch from develop to feat/order-edit-retrieve September 15, 2022 09:29
@adrien2p adrien2p force-pushed the feat/order-edit-creation branch from 7674a1f to a276306 Compare September 15, 2022 09:30
@adrien2p adrien2p changed the base branch from feat/order-edit-retrieve to develop September 15, 2022 09:30
@adrien2p adrien2p force-pushed the feat/order-edit-creation branch from a276306 to b80e296 Compare September 15, 2022 10:51
@adrien2p adrien2p marked this pull request as ready for review September 15, 2022 11:38
@adrien2p adrien2p requested a review from a team as a code owner September 15, 2022 11:38
@adrien2p adrien2p force-pushed the feat/order-edit-creation branch 3 times, most recently from e147a1e to 314d170 Compare September 15, 2022 18:54
srindom
srindom approved these changes Sep 16, 2022
View reviewed changes
Copy link
Collaborator

@srindom srindom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@adrien2p adrien2p force-pushed the feat/order-edit-creation branch 2 times, most recently from d13e660 to 5fa8f34 Compare September 16, 2022 07:46
@adrien2p adrien2p force-pushed the feat/order-edit-creation branch from 5fa8f34 to bb315ad Compare September 16, 2022 07:47
@kodiakhq kodiakhq bot merged commit f7177c9 into develop Sep 16, 2022
@kodiakhq kodiakhq bot deleted the feat/order-edit-creation branch September 16, 2022 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@srindom srindom srindom approved these changes

@fPolic fPolic Awaiting requested review from fPolic

@pKorsholm pKorsholm Awaiting requested review from pKorsholm

Assignees
No one assigned
Labels
automerge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@adrien2p @pKorsholm @srindom @fPolic